fix: cache migration error silent fail#1005
Conversation
Replace the silently ignored cache migration error with a logged warning so users are informed when migration fails. Fixes floatpane#982
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @itniuma2026! Please fix the following issues with your PR:
- Title: Does not follow conventional commits (e.g.,
feat: added something,fix(core): resolved crash). - Title: Is too long (55 characters). The PR title must be strictly under 40 characters.
- Body: Missing the
## What?or## Why?headings required by the PR template.
|
Thanks for the feedback! The issues raised are about the PR title and body formatting, not the code itself — so no code changes are needed here. I'll update the PR title to follow conventional commits and keep it under 40 characters, and add the required |
|
@itniuma2026 please, fix the issues with the PR |
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @andrinoff! Please fix the following issues with your PR:
- Title: Does not follow conventional commits (e.g.,
feat: added something,fix(core): resolved crash). - Title: Is too long (55 characters). The PR title must be strictly under 40 characters.
andrinoff
changed the title
floatpanebot
dismissed stale reviews from themself
Formatting issues have been resolved. Thank you!
andrinoff
left a comment
andrinoff
left a comment
There was a problem hiding this comment.
lgtm. if the next contributions will not follow the format, they will be closed
|
/approve |
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Approved on behalf of @andrinoff via /approve command.
3 participants
What?
Replace the silently ignored cache migration error with a logged warning so users are informed when migration fails.
Why?
Fixes #982